refactor: update all relative export paths to use ts extension #541
Conversation
michaelfaith
changed the title
|
tbh, I don't see the need to use tsup/tsdown. can we just use tsc:
|
|
Honestly, that's fair, since we're not bundling. The only thing is that those could be faster, but I'd have to do a comparison (if that's important to you). |
|
Are |
The two main motivators i see are:
|
michaelfaith
force-pushed
the
refactor/change-relative-import-extensions
branch
from
bd53ff1 to
bdc07e0
Compare
| "lint:js": "eslint --cache --ignore-pattern \"**/*.md\"", | ||
| "lint:js-docs": "eslint --no-inline-config \"**/*.md\"", | ||
| "lint:js": "eslint --cache --ignore-pattern \"**/*.md\" --flag unstable_native_nodejs_ts_config", | ||
| "lint:js-docs": "eslint --no-inline-config \"**/*.md\" --flag unstable_native_nodejs_ts_config", |
There was a problem hiding this comment.
Can we get rid of jiti if we're using this flag?
There was a problem hiding this comment.
We wouldn't need it for the eslint run anymore. But it’s still being used by eslint-remote-tester to parse that config. And, unfortunately, they don't have an option to use node's built-in, like eslint does.
|
Just want to verify the output would still be compatible with the minimum Node versions we support? ( |
Yes, the output tsdown generates still has .js extensions on the imports, and this wouldn't change the compatability of what it emits. I can prepare a before / after diff to share? Unfortunately, adding those versions to the test matrix wouldn't really be an adequate test, since the tests are run on source rather than the build output. But i like that idea. |
| dts: true, | ||
| entry: ['lib/**/*.ts'], | ||
| format: ['esm'], |
There was a problem hiding this comment.
Are there any behavior changes from this tsup/tsdown conversion?
There was a problem hiding this comment.
No, it's meant to be a drop in replacement, just faster. If we were able to set isolatedModules to true in the tsconfig, it would be even faster. But the way the plugin is setup, we can't really do that, and still get rich type information. So, yeah, just swapping one for the other, won't change anything. I was able to remove some of those settings because tsdown will infer them from the package.json.
Coming from #540. This change shifts all relative imports to use
.tsextensions, and enablesrewriteRelativeImportExtensionsin the tsconfig. Unfotunatelytsuphas a bug when using this setting (egoist/tsup#1271), so I switched bundlers totsdownthe Vite community's newtsupalternative (which does support this).I also updated the lint CI step to force using the latest LTS (22.18.0) which comes with native type stripping. I also added the eslint flag that allows eslint to use native type stripping.